Change from sequence-per-model to sequence-per-hierarchy when using sequences for key generation #28501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equences for key generation.
| @@ -180,10 +175,10 @@ public static class SqlServerModelBuilderExtensions | |||
| return null; | |||
| } | |||
There was a problem hiding this comment.
Remove this method and CanSetKeySequences, it doesn't seem very useful and the name doesn't really match the functionality
There was a problem hiding this comment.
@AndriySvyryd In this code, should the KeySequences annotations be unconditionally set to null, regardless of configuration source?
public static IConventionModelBuilder? HasValueGenerationStrategy(
this IConventionModelBuilder modelBuilder,
SqlServerValueGenerationStrategy? valueGenerationStrategy,
bool fromDataAnnotation = false)
{
if (modelBuilder.CanSetValueGenerationStrategy(valueGenerationStrategy, fromDataAnnotation))
{
modelBuilder.Metadata.SetValueGenerationStrategy(valueGenerationStrategy, fromDataAnnotation);
if (valueGenerationStrategy != SqlServerValueGenerationStrategy.IdentityColumn)
{
modelBuilder.HasIdentityColumnSeed(null, fromDataAnnotation);
modelBuilder.HasIdentityColumnIncrement(null, fromDataAnnotation);
modelBuilder.HasKeySequences(null, null, fromDataAnnotation);
}
if (valueGenerationStrategy != SqlServerValueGenerationStrategy.SequenceHiLo)
{
modelBuilder.HasHiLoSequence(null, null, fromDataAnnotation);
modelBuilder.HasKeySequences(null, null, fromDataAnnotation);
}
if (valueGenerationStrategy != SqlServerValueGenerationStrategy.Sequence)
{
modelBuilder.HasIdentityColumnSeed(null, fromDataAnnotation);
modelBuilder.HasIdentityColumnIncrement(null, fromDataAnnotation);
modelBuilder.HasHiLoSequence(null, null, fromDataAnnotation);
}
return modelBuilder;
}
return null;
}There was a problem hiding this comment.
No, it should be changed to check the source
AndriySvyryd
approved these changes
Jul 25, 2022
ajcvickers
added a commit
that referenced
this pull request
Jul 26, 2022
…equences for key generation (#28501)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28096