Add sproc support to relational model #28502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sproc support for Output and InputOutput parameters Add sproc support to runtime and compiled models Fixed property overrides not taking the default schema into account Changed EntityType.ShortName() to not include the generic argument Part of #245
|
@roji With this you can start working on the update pipeline part |
roji
approved these changes
Jul 25, 2022
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Infrastructure/RelationalModelValidatorTest.cs
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Infrastructure/RelationalModelValidatorTest.cs
Show resolved
Hide resolved
| var shippingAddressOwnership = orderDetailsType.FindNavigation(nameof(OrderDetails.ShippingAddress)).ForeignKey; | ||
| Assert.True(shippingAddressOwnership.IsRequiredDependent); | ||
|
|
||
| var shippingAddressType = shippingAddressOwnership.DeclaringEntityType; |
There was a problem hiding this comment.
Not used - did something get mangled?
There was a problem hiding this comment.
Was planning to use for asserts, but 820 lines of asserts seemed enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sproc support for Output and InputOutput parameters
Add sproc support to runtime and compiled models
Fixed property overrides not taking the default schema into account
Changed EntityType.ShortName() to not include the generic argument
Part of #245