Query: Use object.Equals rather than Expression.Equal when constructing comparison in query #28608
Conversation
…ng comparison in query Not all types implement equality operator, so it can throw exception. Reference types, Nullable<T> & known types are ok to be used with Expression.Equal Originally reported in npgsql/efcore.pg#2458
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Query handles ExpressionType.Equal/object.Equals/a.Equals(b) in same way so this is fine change to make for query. I didn't touch code in non-query areas. |
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
|
Ah crap, forgot to remove the auto-merge label again... See comment above if you want to address it. |
ajcvickers
changed the title
Not all types implement equality operator, so it can throw exception.
Reference types, Nullable & known types are ok to be used with Expression.Equal
Originally reported in npgsql/efcore.pg#2458