Addressing API review feedback regarding json columns #28685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maumar
commented
Aug 11, 2022
maumar
commented
- renamed JsonColumnName to ContainerColumnName,
- renamed JsonColumnTypeMapping to ContainerColumnTypeMapping,
- changed RelationalModelValidator.ValidateJsonEntityProperties to protected method,
- moved JsonPropertyName methods on navigation into entity
src/EFCore.Relational/Extensions/RelationalEntityTypeBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ public class RelationalNavigationJsonPropertyNameAttributeConvention : | |||
| { | |||
| if (!string.IsNullOrWhiteSpace(attribute.Name)) | |||
| { | |||
| navigationBuilder.HasJsonPropertyName(attribute.Name, fromDataAnnotation: true); | |||
| navigationBuilder.Metadata.TargetEntityType.Builder.HasJsonPropertyName(attribute.Name, fromDataAnnotation: true); | |||
There was a problem hiding this comment.
So the attribute is the only way of setting the JsonPropertyName right now? Can you file an issue to make ToJson set it?
There was a problem hiding this comment.
you can use builder APIs also:
OwnedNavigationBuilder HasJsonPropertyName
and
PropertyBuilder HasJsonPropertyName
AndriySvyryd
approved these changes
Aug 12, 2022
maumar
force-pushed
the
json_api_review
branch
from
4fbdcf9
to
fce4868
Compare
- renamed JsonColumnName to ContainerColumnName, - renamed JsonColumnTypeMapping to ContainerColumnTypeMapping, - changed RelationalModelValidator.ValidateJsonEntityProperties to protected method, - moved JsonPropertyName methods on navigation into entity
maumar
force-pushed
the
json_api_review
branch
from
fce4868
to
1c7ef8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.