Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters #28734

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Remove unused parameters #28734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/EFCore.Relational/Metadata/Builders/IConventionStoredProcedureBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,16 @@ public interface IConventionStoredProcedureBuilder : IConventionAnnotatableBuild
/// <summary>
/// Configures a new column that contains the rows affected for this stored procedure if no such column exists.
/// </summary>
/// <param name="propertyName">The property name.</param>
/// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
/// <returns>
/// The builder instance if the configuration was applied, <see langword="null" /> otherwise.
/// </returns>
IConventionStoredProcedureResultColumnBuilder? HasRowsAffectedResultColumn(string propertyName, bool fromDataAnnotation = false);
IConventionStoredProcedureResultColumnBuilder? HasRowsAffectedResultColumn(bool fromDataAnnotation = false);

/// <summary>
/// Returns a value indicating whether a column that contains the rows affected can be used for stored procedure.
/// </summary>
/// <param name="propertyName">The property name.</param>
/// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
/// <returns><see langword="true" /> if the column of the result can be used for the stored procedure.</returns>
bool CanHaveRowsAffectedResultColumn(string propertyName, bool fromDataAnnotation = false);
bool CanHaveRowsAffectedResultColumn(bool fromDataAnnotation = false);
}
5 changes: 2 additions & 3 deletions src/EFCore.Relational/Metadata/Internal/InternalStoredProcedureBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,11 @@ bool IConventionStoredProcedureBuilder.CanHaveResultColumn(string propertyName,

/// <inheritdoc />
[DebuggerStepThrough]
IConventionStoredProcedureResultColumnBuilder? IConventionStoredProcedureBuilder.HasRowsAffectedResultColumn(
string propertyName, bool fromDataAnnotation)
IConventionStoredProcedureResultColumnBuilder? IConventionStoredProcedureBuilder.HasRowsAffectedResultColumn(bool fromDataAnnotation)
=> HasRowsAffectedResultColumn(fromDataAnnotation ? ConfigurationSource.DataAnnotation : ConfigurationSource.Convention);

/// <inheritdoc />
[DebuggerStepThrough]
bool IConventionStoredProcedureBuilder.CanHaveRowsAffectedResultColumn(string propertyName, bool fromDataAnnotation)
bool IConventionStoredProcedureBuilder.CanHaveRowsAffectedResultColumn(bool fromDataAnnotation)
=> CanHaveRowsAffectedResultColumn(fromDataAnnotation ? ConfigurationSource.DataAnnotation : ConfigurationSource.Convention);
}