Use unmapped FKs for topological order when propagating store-generated values #28851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue28654
branch
2 times, most recently
from
d2e9847
to
639fa3f
Compare
smitpatel
reviewed
Aug 24, 2022
smitpatel
reviewed
Aug 24, 2022
smitpatel
reviewed
Aug 24, 2022
smitpatel
reviewed
Aug 24, 2022
smitpatel
reviewed
Aug 24, 2022
smitpatel
reviewed
Aug 24, 2022
smitpatel
approved these changes
Aug 24, 2022
|
I'd like to take a look at this as well, but lots of stuff going on... If it's not urgent, can we wait a day or two before merging? |
AndriySvyryd
force-pushed
the
Issue28654
branch
from
639fa3f
to
3d2757c
Compare
smitpatel
reviewed
Aug 24, 2022
|
@ajcvickers Ready for M2 approval. |
roji
approved these changes
Aug 30, 2022
src/EFCore.Relational/Update/Internal/CompositeRowValueFactory.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
Issue28654
branch
from
3d2757c
to
70136a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28654
@roji This contains most of the implementation needed for #28703