Fix to #28845 - JSON: add support for partial update to update just a single scalar property, rather than entire entities #28862
Conversation
| @@ -251,6 +252,13 @@ public virtual IColumnModification AddColumnModification(in ColumnModificationPa | |||
| protected virtual IColumnModification CreateColumnModification(in ColumnModificationParameters columnModificationParameters) | |||
| => new ColumnModification(columnModificationParameters); | |||
|
|
|||
| private sealed class JsonPartialUpdateInfo | |||
There was a problem hiding this comment.
| private sealed class JsonPartialUpdateInfo | |
| private struct JsonPartialUpdateInfo |
There was a problem hiding this comment.
I'm modifying Property and PropertyValue later and also can return null JsonPartialUpdateInfo from FindJsonPartialUpdateInfo, so I find it more convenient to keep as class. Will change to struct if you feel strongly about it tho.
|
|
||
| stringBuilder.Append("JSON_VALUE("); | ||
| base.AppendUpdateColumnValue(updateSqlGeneratorHelper, columnModification, stringBuilder, name, schema); | ||
| stringBuilder.Append(", '$.v')"); |
There was a problem hiding this comment.
This is not ideal, have you tried using an array instead, so we don't need to have magic strings?
There was a problem hiding this comment.
I went for a smallest structure in terms of characters that we need to send over the wire. I can switch to array and access the 1st element, should work just the same
There was a problem hiding this comment.
array actually saves a few characters (1 char longer on the access but 4 chars shorter on the json string itself
There was a problem hiding this comment.
Ok. And have you tried sending the naked value and using $?
… single scalar property, rather than entire entities Optimization for partial updates - when only one property is modified on the entity we can change it directly, rather than rewriting the JSON element for the entire entity. To avoid string formatting issues we construct faux JSON array and insert the value that is to be the replacement, and then in the update statement we extract the value using JSON_VALUE. In case of numeric or bool we need an additional convert statement around the value. Fixes #28845
Optimization for partial updates - when only one property is modified on the entity we can change it directly, rather than rewriting the JSON element for the entire entity.
To avoid string formatting issues we construct faux JSON element and insert the value that is to be the replacement, and then in the update statement we extract the value using JSON_VALUE.
In case of numeric or bool we need an additional convert statement around the value.
Fixes #28845