Avoid cascade cycles on SQL Server for derived-type referencing many-to-many #28937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndriySvyryd I just realized that maybe we should only do this when both types are mapped to the same table? So, for TPH? Or would it be a cycle anyway? |
Yes, just TPH |
|
In fact, the check should only be about the tables, not inheritance, as both principals could be table-sharing. |
For TPT it wouldn't be cycle, but multiple paths, which also fails. |
ajcvickers
force-pushed
the
SubSandwichDonut0831
branch
from
9497aae
to
3591dae
Compare
ajcvickers
force-pushed
the
SubSandwichDonut0831
branch
from
3591dae
to
62e8e3f
Compare
|
@AndriySvyryd New version up. |
AndriySvyryd
reviewed
Sep 1, 2022
| var inverseSkipNavigation = skipNavigation.Inverse!; | ||
|
|
||
| var deleteBehavior = DefaultDeleteBehavior(skipNavigation); | ||
| var inverseDeleteBehavior = DefaultDeleteBehavior(inverseSkipNavigation); |
There was a problem hiding this comment.
Probably a corner case, but the inverse nav could already be configured as ClientCascade explicitly, so we wouldn't need to do anything
AndriySvyryd
approved these changes
Sep 1, 2022
ajcvickers
force-pushed
the
SubSandwichDonut0831
branch
from
62e8e3f
to
3c2e867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28633