Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecuteDelete for aggregate root when only owned types are sharing the table #29023

Merged
merged 1 commit into from
Sep 9, 2022
Merged

ExecuteDelete for aggregate root when only owned types are sharing the table #29023

merged 1 commit into from
Sep 9, 2022

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Sep 8, 2022 •
edited by ajcvickers
Loading

Resolves #28671

roji
roji approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits and a question

test/EFCore.Relational.Specification.Tests/BulkUpdates/NonSharedModelBulkUpdatesTestBase.cs Show resolved Hide resolved
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs Outdated Show resolved Hide resolved
@smitpatel smitpatel force-pushed the smit/executedeleteaggregate branch from befb0f7 to afaa17c Compare September 9, 2022 17:05
@smitpatel smitpatel merged commit c75abeb into release/7.0 Sep 9, 2022
@smitpatel smitpatel deleted the smit/executedeleteaggregate branch September 9, 2022 22:08
@smitpatel smitpatel mentioned this pull request Sep 9, 2022
Closed
@ajcvickers ajcvickers changed the title ExecuteDelete for aggregate root when only owned types are sharing th… ExecuteDelete for aggregate root when only owned types are sharing the table Sep 15, 2022
@ajcvickers ajcvickers mentioned this pull request Sep 15, 2022
Closed
@gabriel-systems
Copy link

Is there any plans for ExecuteDelete to support : -

  1. enable/disable triggers, transactions, cascade
  2. output options for SQL server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecuteDelete for owner when only its owned types are sharing the same table
3 participants
@smitpatel @gabriel-systems @roji