Allow FK type in database to be different from PK type #29026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
BigIntSlim0906
branch
from
7dd25c8
to
19eb728
Compare
AndriySvyryd
reviewed
Sep 9, 2022
|
|
||
| /// <summary> | ||
| /// This is an internal API that supports the Entity Framework Core infrastructure and not subject to | ||
| /// the same compatibility standards as public APIs. It may be changed or removed without notice in | ||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | ||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| public virtual IEqualityComparer<object?[]> EqualityComparer { get; } | ||
| public virtual IEqualityComparer<object?[]> EqualityComparer { get; set; } = null!; |
There was a problem hiding this comment.
Suggested change
| public virtual IEqualityComparer<object?[]> EqualityComparer { get; set; } = null!; | |
| public virtual IEqualityComparer<object?[]> EqualityComparer { get; protected set; } = null!; |
Good candidate to use required
AndriySvyryd
reviewed
Sep 9, 2022
Comment on lines
95
to
96
| IReadOnlyModificationCommand command, | ||
| bool fromOriginalValues, |
There was a problem hiding this comment.
Adding work for the next cleanup, I see 🤔
AndriySvyryd
reviewed
Sep 9, 2022
| } | ||
| catch (TargetInvocationException exception) | ||
| { | ||
| throw exception.InnerException ?? exception; |
There was a problem hiding this comment.
Yes, but is is rare; see tests. This would happen when using SaveChanges with store types for which we can't convert values. So, for example, and int and a GUID. But its hard to imagine a sane use of relationships, even without constraints in the database, that would get here.
There was a problem hiding this comment.
I think it's not worth it to add the try just to make the exception a bit better
AndriySvyryd
reviewed
Sep 9, 2022
|
|
||
| using System.Transactions; | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore; |
AndriySvyryd
approved these changes
Sep 9, 2022
Approach uses built-in value converters to convert FK value to type of PK. Fixes #28392
ajcvickers
force-pushed
the
BigIntSlim0906
branch
from
19eb728
to
533f6b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach uses built-in value converters to convert FK value to type of PK.
Fixes #28392