Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't undelete dependents if principal key changes #29028

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Don't undelete dependents if principal key changes #29028

merged 1 commit into from
Sep 9, 2022

Conversation

AndriySvyryd
Copy link
Member

  • Don't undelete dependents if principal key changes
  • Re-set ordinal values when the principal is added, not only when it's modified
  • Mark the ordinal property as ValueGenerated.OnAddOrUpdate
  • Override all JSON values for a replaced dependent

Fixes #27918
Fixes #27272
Fixes #24828

@AndriySvyryd
Don't undelete dependents if principal key changes
43ea81d 
Re-set ordinal values when the principal is added, not only when it's modified
Mark the ordinal property as ValueGenerated.OnAddOrUpdate
Override all JSON values for a replaced dependent

Fixes #27918
Fixes #27272
Fixes #24828
@AndriySvyryd AndriySvyryd changed the title Fix several issues around ordinal keys changing Don't undelete dependents if principal key changes Sep 9, 2022
@AndriySvyryd AndriySvyryd merged commit f20729d into release/7.0 Sep 9, 2022
@AndriySvyryd AndriySvyryd deleted the Issue28600 branch September 9, 2022 18:20
@ajcvickers ajcvickers mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriySvyryd @ajcvickers