Code cleanup--tests #29030
Merged
Code cleanup--tests #29030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Sep 9, 2022
| @@ -64,7 +66,9 @@ private class MockOperation<T> : OperationExecutor.OperationBase | |||
| { | |||
| public MockOperation(IOperationResultHandler resultHandler, Func<T> action) | |||
| : base(resultHandler) | |||
| => Execute(action); | |||
| { | |||
There was a problem hiding this comment.
Maybe there's a rule to allow this?
There was a problem hiding this comment.
Yes, but we previously decided to not use expression bodies for constructors.
| @@ -90,7 +90,8 @@ public void Test_new_annotations_handled_for_entity_types() | |||
| RelationalAnnotationNames.ModelDependencies, | |||
| RelationalAnnotationNames.FieldValueGetter, | |||
| RelationalAnnotationNames.JsonPropertyName, | |||
| RelationalAnnotationNames.ContainerColumnName, // Appears on entity type but requires specific model (i.e. owned types that can map to json, otherwise validation throws) | |||
| RelationalAnnotationNames | |||
There was a problem hiding this comment.
Can just put the comment on the preceding line or something
| { | ||
| Name = "Initial", | ||
| }; | ||
| var entity = new Entity { Name = "Initial", }; |
There was a problem hiding this comment.
Suggested change
| var entity = new Entity { Name = "Initial", }; | |
| var entity = new Entity { Name = "Initial" }; |
| @@ -34,7 +34,7 @@ public void Compare_returns_0_only_for_commands_that_are_equal() | |||
| entry1.SetEntityState(EntityState.Added); | |||
| var modificationCommandAdded = modificationCommandSource.CreateModificationCommand( | |||
| new ModificationCommandParameters(table, false, false, null, new ParameterNameGenerator().GenerateNext)); | |||
| // new ModificationCommandParameters("A", null, false, false, null, new ParameterNameGenerator().GenerateNext)); | |||
| // new ModificationCommandParameters("A", null, false, false, null, new ParameterNameGenerator().GenerateNext)); | |||
There was a problem hiding this comment.
Suggested change
| // new ModificationCommandParameters("A", null, false, false, null, new ParameterNameGenerator().GenerateNext)); |
Fixes #28964
ajcvickers
force-pushed
the
TroubleTown0909
branch
from
e1417af
to
ccd020b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28964