Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SQLitePCLRaw 2.1.2-pre20220913165057 #29074

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

bricelam
Copy link
Contributor

No description provided.

@bricelam bricelam requested a review from a team September 13, 2022 18:30
NuGet.config Outdated Show resolved Hide resolved
@ajcvickers
Copy link
Member

@bricelam Should we be doing this for 7.0? We'll need to make sure we have a stable release in time for the GA build.

@bricelam
Copy link
Contributor Author

bricelam commented Sep 14, 2022

This SQLitePCLRaw release adds support for Wasm on .NET 7. I think it's a risk either way, so I'll let you make the call.

Worst case scenario if we don't take this is that users will have to manually update the SQLitePCLRaw.bundle_e_sqlite3 package in order to get Wasm to work.

@ericsink Do you have an estimate for a non-prerelease?

@ericsink
Copy link

I can do a non-pre release anytime you want, including today. I was stalling to see if clarity emerged on a couple of other issues, but there's nothing there yet, so the updated Wasm binaries would be the only effective change since 2.1.1.

@bricelam
Copy link
Contributor Author

bricelam commented Sep 14, 2022

Note, this will resolve the issue originally reported in dotnet/runtime#74988.

@ajcvickers
Copy link
Member

Let's do it!

@bricelam
Copy link
Contributor Author

@ericsink We're branching for RC2 soon, so a prerelease is still OK. At the latest we'll probably need a final version by like Oct 7, so no rush. As always though, the sooner the better, so we have time to react to any last-minute surprises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants