Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Fix to #29279 - EF7 - GroupBy on Json column property + First/FirstOrDefault generates incorrect SQL #29288

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[release/7.0] Fix to #29279 - EF7 - GroupBy on Json column property + First/FirstOrDefault generates incorrect SQL #29288

merged 1 commit into from
Oct 7, 2022

Commits on Oct 7, 2022

  1. Fix to #29279 - EF7 - GroupBy on Json column property + First/FirstOr… 

    …Default generates incorrect SQL

Problem was that in VisitChildren for JsonQueryExpression we were not passing key columns stored in _keyPropertyMap thru the visitor, so the aliases got out of sync.
Fix is to process these key columns also and then update the JsonQueryExpression with new map if any of the columns have been modified by the visitor.

Fixes #29279
    @maumar
    maumar committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    85ef52f View commit details
    Browse the repository at this point in the history