Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SqlClient to 5.0.1 #29307

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Update SqlClient to 5.0.1 #29307

merged 1 commit into from
Oct 10, 2022

Conversation

roji
Copy link
Member

@roji roji commented Oct 10, 2022

This is a patch update of our SqlClient dependency from 5.0.0 to 5.0.1 (see dotnet/SqlClient#1794). We should do this for 7.0, so doing this manually rather than waiting for dependabot.

Closes #29301

@ajcvickers
Copy link
Member

ajcvickers commented Oct 10, 2022

@roji @ErikEJ Tactics is going to ask if we are confident in 5.0.1. How long has it been out? Any issues reported so far?

@roji
Copy link
Member Author

roji commented Oct 10, 2022

I'd say I'm generally a bit more confident in 5.0.1 than in 5.0.0 :)

It's true that 5.0.1 came out two days ago (compared to 5.0.0 which came out two months ago). I understand the logic of giving even patch versions some time to prove themselves, though I still think it's probably better to choose a patch which fixes known bugs which are already there (e.g. dotnet/SqlClient#1766) rather than be very conservative against unknown bugs.

But if you'd rather wait until our 7.0.1 we can do that.

@ajcvickers ajcvickers added this to the 7.0.0 milestone Oct 10, 2022
@ajcvickers ajcvickers removed this from the 7.0.0 milestone Oct 10, 2022
@ajcvickers ajcvickers merged commit 886c2e2 into dotnet:release/7.0 Oct 10, 2022
@roji roji deleted the release/7.0 branch October 10, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants