Use C# 11 raw SQL literals for all SQL baselines #29350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Oct 14, 2022
roji
force-pushed
the
StringLiteralsYayyy
branch
from
d724d11
to
eaac35c
Compare
|
@roji FYI, I checkout out your branch and all tests passed locally. Let's see if the infra issues get fixed, but if not we might want to just merge. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roji
force-pushed
the
StringLiteralsYayyy
branch
from
eaac35c
to
2fbbb0d
Compare
roji
force-pushed
the
StringLiteralsYayyy
branch
from
2fbbb0d
to
0d5c579
Compare
|
@ajcvickers the failures were actually my fault, a connection string change to config.json accidentally slipped in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test-only change. Since it affects so many files, we want to get this into 7.0 to avoid merge conflicts when later backporting patches.
The massive baseline changes are in a separate commit from baseline management changes for easier reviewing.
Part of #28260