Fix to #29365 - Query/Test: convert FromSql tests to use query infra #29402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @maumar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
ping @roji @AndriySvyryd |
roji
approved these changes
Nov 10, 2022
| public virtual Task FromSqlRaw_queryable_multiple_composed(bool async) | ||
| => AssertQuery( | ||
| async, | ||
| ss => from c in ((DbSet<Customer>)ss.Set<Customer>()).FromSqlRaw(NormalizeDelimitersInRawString("SELECT * FROM [Customers]")) |
There was a problem hiding this comment.
I wonder... For the overload of AssertQuery that accepts both actual and expected queries, maybe the actual lambda could have DbSet directly accessible somehow, to avoid all the casts to DbSet here... Not critical.
There was a problem hiding this comment.
worth considering especially if/when we add more stuff that composes on dbset directly
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29365