[release/2.1] Update to SQLitePCLRaw 1.1.15 #29433

bricelam · 2022-10-26T18:40:50Z

bricelam · 2022-10-26T18:41:38Z

Need to mirror SQLitePCLRaw.bundle_green 2.1.2

wtgodbe · 2022-10-26T19:17:12Z

Need to mirror SQLitePCLRaw.bundle_green 2.1.2

@dotnet/dnceng can somebody help with this?

wtgodbe · 2022-10-26T19:19:18Z

This will also require a submodule update in aspnetcore's 2.1 branch, and (I think) a change to patchconfig.props - @dougbu will that be sufficient to get these EF packages building?

dougbu · 2022-10-26T19:20:58Z

Need to mirror SQLitePCLRaw.bundle_green 2.1.2

May need to ask in First Responders channel.

dougbu · 2022-10-26T19:32:56Z

will that be sufficient to get these EF packages building?

No, will need to change build/submodules.props in dotnet/aspnetcore.

Also need to update versions.props and probably build/dependencies.props in this PR to align w/ next version. Or we should do a branding PR then merge this, both before updating the submodule in dotnet/aspnetcore and changing its build to build EF.

dougbu · 2022-10-26T19:36:42Z

See #15369 for example

AlitzelMendez · 2022-10-26T19:56:50Z

Need to mirror SQLitePCLRaw.bundle_green 2.1.2

@dotnet/dnceng can somebody help with this?

done :)

wtgodbe · 2022-10-26T20:01:54Z

/azp run

wtgodbe · 2022-10-26T20:02:06Z

#29437

azure-pipelines · 2022-10-26T20:02:25Z

Azure Pipelines successfully started running 1 pipeline(s).

bricelam · 2022-11-02T17:21:36Z

Looks like it's failing because it's using version 2.1.526 of the SDK which doesn't support NuGet's buildTransitive directory.

bricelam · 2022-11-02T17:25:33Z

In other words, this will break compatibility with VS2017

dougbu · 2022-11-04T03:18:46Z

@bricelam is there a workaround for the problem you described❔ Would be good to get this in this month.

ajcvickers · 2022-11-15T14:25:37Z

@bricelam Is there anything blocking this now that we have the go-ahead from Tactics on using the newer SDK?

bricelam · 2022-11-23T00:32:05Z

Hmm... Trying to manually verify the packages, I get Library e_sqlite3 not found. If I specify a RuntimeIdentifier, it works.

@ericsink I don't think the build script is working as expected. Instead of a runtimes directory with all three Windows dlls under it, I see one (arbitrary?) e_sqlite3.dll copied to the output directory. In other words, I don't think the Link metadata is working as expected...

ericsink · 2022-11-23T01:02:39Z

Coming up to speed here on the context... you're trying to use recent builds of SQLitePCLRaw (2.1.2) with EFCore 2.1? Which is several years old? It never occurred to me that my current builds would need to work with configurations that old, although I can't defend any reason why not.

Anyway, that targets file for .NET Framework scenarios is a never ending source of problems. The last time somebody convinced me to make significant changes in that area was ericsink/SQLitePCL.raw#389 , the goal of which was to support RuntimeIdentifier, but since those changes, I've seen various problems happening when RuntimeIdentifier is NOT present.

It's also possible that I broke something with an associated change to the code in the dynamic provider.

I'll need to dig into this to figure things out. If by chance you want to suggest a fix, feel free.

ericsink · 2022-11-23T01:37:56Z

So I constructed a quick test, and if I tweak the Condition on that ItemGroup to remove '$(RuntimeIdentifier)' == '' AND, then I once again get a runtimes directory with all 3 Windows rids under it.

So it would seem that RuntimeIdentifier is set to something even when it is not set, and depending on it being '' isn't going to work. That change was made in commit b4d03d52cbb485fe1b6fad9586687c21e1371913 in ericsink/SQLitePCL.raw. I can remove that Condition, but then I might re-break the problem reported in ericsink/SQLitePCL.raw#389

I also do still get that "one (arbitrary?) e_sqlite3.dll copied to the output directory". I'm not sure what's putting it there. Perhaps this is related to whatever RuntimeIdentifier default value is showing up, but it's interesting to note that whatever e_sqlite3.dll is being placed there, it doesn't seem to actually work at runtime.

ericsink · 2022-11-23T17:32:13Z

Running a build with -v diag includes the following:

Property reassignment: $(RuntimeIdentifier)="win7-x86" (previous value: "") at C:\Program Files\dotnet\sdk\7.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets (61,5)

Which seems consistent with the observation above that it is (no longer | not) safe to assume that RuntimeIdentifier is an empty string if the user did not set it.

I find the available documentation to be lacking when it comes to arcane details of the behavior of msbuild properties like this. Guidance welcome.

ericsink · 2022-11-29T17:29:55Z

@bricelam Any suggestions for what I should do here?

My goal would be to find a way to fix that targets file such that:

When someone explicitly sets RuntimeIdentifier, it works the way it does now, with the proper version of e_sqlite3.dll appearing in the output directory.
And if RuntimeIdentifier is not explicitly set, we get the "runtimes directory with all 3 Windows rids under it", but NOT the "one (arbitrary?) e_sqlite3.dll copied to the output directory"

But I'm not sure (yet) how to do that.

It would seem that AFTER @AArnott suggested the current approach (the '$(RuntimeIdentifier)' == '' condition, back in ericsink/SQLitePCL.raw#389 -- Hi Andrew), the .NET SDK may have changed the way RuntimeIdentifier is used, giving it a default value.

AArnott · 2022-11-30T15:44:37Z

I doubt RuntimeIdentifier has a default value set. But it gets set in a variety of ways including dotnet publish -r win-x86, or maybe even based on the Platform property.
What .NET SDK is being used at this point, and what is the TargetFramework? 2.1 is long out of support.

ajcvickers · 2022-11-30T15:52:46Z

@AArnott 2.1 is still supported for ASP.NET Core applications targeting .NET Framework. This is for an MSRC relating to that.

ericsink · 2022-11-30T15:54:14Z

I used the term "default value" rather imprecisely, intending to mean "any value that property ever gets that was not assigned by the developer editing the csproj file". :-)

AArnott · 2022-11-30T16:20:09Z

@ajcvickers Makes sense. And what version of the .NET SDK (or Visual Studio) are you using?

bricelam · 2022-11-30T20:02:32Z

@AArnott I was using the 7.0 SDK to manually verify the packages. (With a project targeting .NET Framework)

dougbu · 2023-01-11T19:17:35Z

@ajcvickers @bricelam, is this a tell-mode change and should we make sure we build dotnet/aspnetcore release/2.1 (which includes efcore as a submodule) for March❔

/cc @wtgodbe

bricelam · 2023-01-11T19:38:33Z

@dougbu We ran into issues with this change and have taken a new approach. As soon as the new build passes, yes, let's get it into the March 2.1.x patch. And yes, ASP.NET Identity should update its dependencies on these EF packages.

bricelam · 2023-01-11T19:41:07Z

We may need to mirror the 1.1.15 versions of these packages when they're available: (If we do that on 2.1)

SQLitePCLRaw.bundle_green
SQLitePCLRaw.lib.e_sqlite3.v110_xp

dougbu · 2023-01-11T19:41:09Z

And yes, ASP.NET Identity should update its dependencies on these EF packages.

IIRC, that happens automatically when we update dotnet/aspnetcore to produce dotnet/efcore packages. It's all hinged on a one-line change in aspnetcore.

dougbu · 2023-01-11T19:44:54Z

We may need to mirror the 1.1.15 versions of these packages when they're available: (If we do that on 2.1)

release/2.1 branches use dotnet-public too. Unless the feed already contains what you need, head over to First Responders and request them.

Part of dotnet#29429

bricelam · 2023-01-11T23:27:44Z

test/EFCore.Sqlite.FunctionalTests/Query/SimpleQuerySqliteTest.cs

@@ -684,6 +685,12 @@ public override void Select_datetime_millisecond_component()
        }
 #endif

+        [ConditionalFact(Skip = "Issue#21541")]


FYI, this actually passes on .NET Framework and isn't regressed there. Just skipping everywhere since that's what we did for a while in downstream branches.

bricelam · 2023-01-11T23:54:45Z

/azp run

azure-pipelines · 2023-01-11T23:54:53Z

Azure Pipelines successfully started running 1 pipeline(s).

bricelam requested a review from a team October 26, 2022 18:40

This comment was marked as outdated.

Sign in to view

bricelam force-pushed the printf21 branch from 741bce9 to ab84183 Compare November 17, 2022 23:15

ajcvickers approved these changes Nov 18, 2022

View reviewed changes

ericsink mentioned this pull request Nov 23, 2022

Yet another problem with .NET Framework and the targets file ericsink/SQLitePCL.raw#527

Open

bricelam force-pushed the printf21 branch from ab84183 to f8cc108 Compare January 11, 2023 19:38

Update to SQLitePCLRaw 1.1.15

74055e1

Part of dotnet#29429

bricelam force-pushed the printf21 branch from f8cc108 to 74055e1 Compare January 11, 2023 23:25

bricelam commented Jan 11, 2023

View reviewed changes

bricelam changed the title ~~[release/2.1] Update to SQLitePCLRaw 2.1.2~~ [release/2.1] Update to SQLitePCLRaw 1.1.15 Jan 11, 2023

bricelam added the tell-mode label Jan 12, 2023

bricelam added this to the 2.1.x milestone Jan 12, 2023

bricelam merged commit 74055e1 into dotnet:release/2.1 Jan 12, 2023
4 checks passed

bricelam deleted the printf21 branch January 12, 2023 18:09

bricelam mentioned this pull request Jan 12, 2023

[release/2.1] Bump modules/EntityFrameworkCore from 4bd499b to 74055e1 dotnet/aspnetcore#46062

Merged

ajcvickers removed this from the 2.1.x milestone Jan 12, 2023

ajcvickers mentioned this pull request Jan 19, 2023

Latest news and progress on .NET 8 and EF8 #29989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/2.1] Update to SQLitePCLRaw 1.1.15 #29433

[release/2.1] Update to SQLitePCLRaw 1.1.15 #29433

bricelam commented Oct 26, 2022 •

edited

Loading

bricelam commented Oct 26, 2022 •

edited

Loading

wtgodbe commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

dougbu commented Oct 26, 2022

dougbu commented Oct 26, 2022

dougbu commented Oct 26, 2022

AlitzelMendez commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

azure-pipelines bot commented Oct 26, 2022

This comment was marked as outdated.

bricelam commented Nov 2, 2022

bricelam commented Nov 2, 2022 •

edited

Loading

dougbu commented Nov 4, 2022

ajcvickers commented Nov 15, 2022

bricelam commented Nov 23, 2022

ericsink commented Nov 23, 2022

ericsink commented Nov 23, 2022

ericsink commented Nov 23, 2022 •

edited

Loading

ericsink commented Nov 29, 2022

AArnott commented Nov 30, 2022

ajcvickers commented Nov 30, 2022

ericsink commented Nov 30, 2022

AArnott commented Nov 30, 2022

bricelam commented Nov 30, 2022

dougbu commented Jan 11, 2023

bricelam commented Jan 11, 2023

bricelam commented Jan 11, 2023

dougbu commented Jan 11, 2023

dougbu commented Jan 11, 2023

bricelam Jan 11, 2023

bricelam commented Jan 11, 2023

azure-pipelines bot commented Jan 11, 2023

[release/2.1] Update to SQLitePCLRaw 1.1.15 #29433

[release/2.1] Update to SQLitePCLRaw 1.1.15 #29433

Conversation

bricelam commented Oct 26, 2022 • edited Loading

bricelam commented Oct 26, 2022 • edited Loading

wtgodbe commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

dougbu commented Oct 26, 2022

dougbu commented Oct 26, 2022

dougbu commented Oct 26, 2022

AlitzelMendez commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

wtgodbe commented Oct 26, 2022

azure-pipelines bot commented Oct 26, 2022

This comment was marked as outdated.

bricelam commented Nov 2, 2022

bricelam commented Nov 2, 2022 • edited Loading

dougbu commented Nov 4, 2022

ajcvickers commented Nov 15, 2022

bricelam commented Nov 23, 2022

ericsink commented Nov 23, 2022

ericsink commented Nov 23, 2022

ericsink commented Nov 23, 2022 • edited Loading

ericsink commented Nov 29, 2022

AArnott commented Nov 30, 2022

ajcvickers commented Nov 30, 2022

ericsink commented Nov 30, 2022

AArnott commented Nov 30, 2022

bricelam commented Nov 30, 2022

dougbu commented Jan 11, 2023

bricelam commented Jan 11, 2023

bricelam commented Jan 11, 2023

dougbu commented Jan 11, 2023

dougbu commented Jan 11, 2023

bricelam Jan 11, 2023

Choose a reason for hiding this comment

bricelam commented Jan 11, 2023

azure-pipelines bot commented Jan 11, 2023

bricelam commented Oct 26, 2022 •

edited

Loading

bricelam commented Oct 26, 2022 •

edited

Loading

bricelam commented Nov 2, 2022 •

edited

Loading

ericsink commented Nov 23, 2022 •

edited

Loading