Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add CodeQL3000 run to efcore-ci-official #29439

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 27, 2022

dougbu added a commit to dougbu/efcore that referenced this pull request Oct 27, 2022
- backport of dotnet#29425 via dotnet#29438 and dotnet#29439
- add new schedule for a weekly run
- add top-level parameter enabling CodeQL3000 in manual builds
- mix CodeQL3000 tasks into regular build; avoid large duplications
  - skip other jobs in CodeQL3000 runs
  - set `$(UseSharedCompilation)` to `false` to ease analysis
- tag CodeQL3000 runs
- add a tsaoptions.json file
  - cribbed values from our eng/sdl-tsa-vars.config file

nit: `s/master/main/`
dougbu added a commit to dougbu/efcore that referenced this pull request Oct 31, 2022
- backport of dotnet#29425 via dotnet#29438 and dotnet#29439
- add new schedule for a weekly run
- add top-level parameter enabling CodeQL3000 in manual builds
- mix CodeQL3000 tasks into regular build; avoid large duplications
  - skip other jobs in CodeQL3000 runs
  - set `$(UseSharedCompilation)` to `false` to ease analysis
- add tag indicating CodeQL3000 tasks did useful work
  - ignore no-op task executions
- add a tsaoptions.json file
  - cribbed values from our eng/sdl-tsa-vars.config file

nit: `s/master/main/`
dougbu added a commit to dougbu/efcore that referenced this pull request Oct 31, 2022
- backport of dotnet#29425 via dotnet#29438 and dotnet#29439
- add new schedule for a weekly run
- add top-level parameter enabling CodeQL3000 in manual builds
- mix CodeQL3000 tasks into regular build; avoid large duplications
  - skip other jobs in CodeQL3000 runs
  - set `$(UseSharedCompilation)` to `false` to ease analysis
- add tag indicating CodeQL3000 tasks did useful work
  - ignore no-op task executions
- add a tsaoptions.json file
  - cribbed values from our eng/sdl-tsa-vars.config file

nit: `s/master/main/`
- backport of dotnet#29425 via dotnet#29438
- add new schedule for a weekly run
- add top-level parameter enabling CodeQL3000 in manual builds
- mix CodeQL3000 tasks into regular build; avoid large duplications
  - skip other jobs in CodeQL3000 runs
  - set `$(UseSharedCompilation)` to `false` to ease analysis
- add tag indicating CodeQL3000 tasks did useful work
  - ignore no-op task executions
- add a tsaoptions.json file
  - cribbed values from our eng/sdl-tsa-vars.config file
@dougbu dougbu force-pushed the dougbu/CodeQL3000/release/6.0 branch from 99c94f9 to a42b560 Compare October 31, 2022 03:59
@dougbu
Copy link
Member Author

dougbu commented Oct 31, 2022

I tested this latest revision twice internally w/ the tasks enabled. Both builds were successful.

  • In build #20221030.1, the tasks did real work and the build was correctly tagged.
  • In build #20221030.2, the tasks didn't do much and the build was not tagged. This demonstrates the condition: is correct.

@dougbu dougbu merged commit a51c304 into dotnet:release/6.0 Nov 2, 2022
@dougbu dougbu deleted the dougbu/CodeQL3000/release/6.0 branch November 2, 2022 03:11
dougbu added a commit that referenced this pull request Nov 2, 2022
- backport of #29425 via #29438 and #29439
- add new schedule for a weekly run
- add top-level parameter enabling CodeQL3000 in manual builds
- mix CodeQL3000 tasks into regular build; avoid large duplications
  - skip other jobs in CodeQL3000 runs
  - set `$(UseSharedCompilation)` to `false` to ease analysis
- add tag indicating CodeQL3000 tasks did useful work
  - ignore no-op task executions
- add a tsaoptions.json file
  - cribbed values from our eng/sdl-tsa-vars.config file

nit: `s/master/main/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants