Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DbUpdateException.Entries contain all entries when we can't populate it #29571

Merged
1 commit merged into from
Nov 17, 2022

Conversation

roji
Copy link
Member

@roji roji commented Nov 15, 2022

Closes #29379

@roji roji requested a review from a team November 15, 2022 20:53
@ajcvickers
Copy link
Contributor

Shouldn't it contain all the entries in the batch rather than being empty? @AndriySvyryd?

@roji roji force-pushed the DbUpdateExceptionEntries branch from 004a855 to 16e0afc Compare November 16, 2022 09:53
@roji
Copy link
Member Author

roji commented Nov 16, 2022

@AndriySvyryd @ajcvickers corrected for the exception to reference all entries instead of be empty.

@roji roji force-pushed the DbUpdateExceptionEntries branch from 16e0afc to c56d6be Compare November 16, 2022 13:06
@roji roji changed the title Make DbUpdateException.Entries empty when we can't populate it Make DbUpdateException.Entries contain all entries when we can't populate it Nov 16, 2022
@roji roji force-pushed the DbUpdateExceptionEntries branch from c56d6be to f6d4147 Compare November 17, 2022 09:04
@ghost
Copy link

ghost commented Nov 17, 2022

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 17, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 8fdc756 into dotnet:main Nov 17, 2022
@roji roji deleted the DbUpdateExceptionEntries branch November 17, 2022 10:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Entries Values in DbUpdateException when an error occurs in the SQL MERGE statement during insert
3 participants