[release/7.0] Use simpler Docker tags #29576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dougbu
commented
Nov 16, 2022
dougbu
commented
- similar to [release/6.0] Use simpler Docker tags #29575 but Helix jobs use macOS here
- also align helix.proj (default) Helix queues w/ CI choices
- similar to dotnet#29575 but Helix jobs use macOS here - also align helix.proj (default) Helix queues w/ CI choices
wtgodbe
approved these changes
Nov 16, 2022
smitpatel
reviewed
Nov 16, 2022
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| <PropertyGroup Condition = "'$(SYSTEM_ACCESSTOKEN)' == ''"> | |||
| <!-- Local build outside of Azure Pipeline --> | |||
| <HelixTargetQueues Condition = "'$(HelixTargetQueues)' == ''">Windows.10.Amd64.Open;Ubuntu.2204.Amd64.Open;OSX.1100.Amd64.Open;Ubuntu.2204.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-sqlserver-amd64-20220131172221-d5c5072</HelixTargetQueues> | |||
There was a problem hiding this comment.
Not that it matters too much. Any particular reason to drop windows/Ubuntu from queue here?
There was a problem hiding this comment.
It was dropped in azure-pipelines.yml and this only provides a fallback (that may never be used). From the PR description:
align helix.proj (default) Helix queues w/ CI choices
There was a problem hiding this comment.
It was dropped from pipeline to reduce build time. Fallback is used when running from command line in dev machine. Either way is fine since it is used for debugging from dev machine only, user can easily change to target specific queue.
michellemcdaniel
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.