Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: allow opting out of RETURNING for virtual tables #29679

Closed
wants to merge 1 commit into from

Conversation

roji
Copy link
Member

@roji roji commented Nov 25, 2022

Leaving a hook for checking for a table-based opt out of RETURNING.

@bricelam this is the update pipeline work necessary to fix #29512, i.e. switch between the new RETURNING syntax and the older multi-command SELECT syntax. We now have to decide if we want to add metadata (and migrations) support for virtual columns, or just add a generic opt out of RETURNING. Feel free to push code into this PR (e.g. virtual table metadata/migrations support).

Fixes #29512

Leaving a hook for checking for a table-based opt out of RETURNING

Fixes dotnet#29512
@roji roji changed the title Merge legacy and non-legacy SqliteUpdateSqlGenerator SQLite: allow opting out of RETURNING for virtual tables Nov 25, 2022
@roji
Copy link
Member Author

roji commented Dec 22, 2022

Closing this in favor of #29917

@roji roji closed this Dec 22, 2022
@roji roji deleted the SqliteVirtualTables branch December 22, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite: RETURNING clause doesn't work with virtual tables
1 participant