[release/7.0] Reset query tracking behavior correctly if set on DbContextOptions #29797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #29766
Fixes #29733
Description
When using DbContext pooling, a query tracking behavior of NoTracking could be changed to TrackAll after the context has been returned to the pool and retrieved again.
Customer impact
Queries running with the wrong tracking behavior could result in application crashes, incorrect data, and reduced performance.
How found
Customer reported on 7.0
Regression
Yes, from 6.0.
Testing
Added a tests around this area where the tracking behavior is specified on the options builder.
Risk
Low; simple code change, and a quirk was added to revert back to older behavior.