[release/7.0] Revert shared columns validation breaking change #29867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Dec 16, 2022
|
@AndriySvyryd could you resolve the merge conflict? |
… are used in a key, foreign key or a unique index Fixes #29859
AndriySvyryd
force-pushed
the
Issue29859_7.0
branch
from
aaf9b9b to
04429be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #29866
Fixes #29859
Description
The validation of provider CLR type for shared columns became stricter in 7.0 and it affected cases where the model wasn't actually invalid.
Customer impact
Affected models throw an exception during validation. There is no workaround.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added tests for the affected scenario.
Risk
Low; the fix is to throw in fewer cases, and a quirk was added to revert back to older behavior.