Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex from SqlServerMigrationsSqlGenerator #30069

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

ajcvickers
Copy link
Contributor

Fixes #16175

@ajcvickers ajcvickers requested a review from a team January 14, 2023 19:30
Comment on lines +1401 to +1402
.Replace("\\\n", "")
.Replace("\\\r\n", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Replace("\\\n", "")
.Replace("\\\r\n", "")
.Replace("\\\r\n", "")
.Replace("\\\n", "")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@ajcvickers ajcvickers merged commit db094b7 into main Jan 19, 2023
@ajcvickers ajcvickers deleted the JustAnIrregularMan0114 branch January 19, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegexMatchTimeoutException for SqlServerMigrationsSqlGenerator
2 participants