Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readme for sql server #30466

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Add readme for sql server #30466

merged 4 commits into from
Sep 6, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Mar 13, 2023 •
edited
Loading

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Add readme file for Microsoft.EntityFrameworkCore.SqlServer nuget package [Microsoft.EntityFrameworkCore.SqlServer](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer/8.0.0-preview.1.23111.4)

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Address: #30467, #26556

@lyndaidaii lyndaidaii changed the title add readme for sql server Add readme for sql server Mar 13, 2023
ajcvickers
ajcvickers suggested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking food; needs a few updates.

@ajcvickers ajcvickers merged commit bb8a309 into dotnet:main Sep 6, 2023
@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 6, 2023

Why is there a section about .Design??

ajcvickers added a commit that referenced this pull request Sep 6, 2023
@lyndaidaii @ajcvickers
Add readme for sql server (#30466)
93e6353 
Co-authored-by: Lynn Dai <lind@microsoft.com>
Co-authored-by: Arthur Vickers <ajcvickers@hotmail.com>
@ajcvickers
Copy link
Contributor

Why is there a section about .Design??

Copy/paste error. Should be fixed now.

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 6, 2023

I was looking at the wrong branch, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees

@ajcvickers ajcvickers

Labels
propose-close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyndaidaii @ErikEJ @ajcvickers @bricelam