Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of the sentinel value that indicates a property has not been set #30760

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

ajcvickers
Copy link
Contributor

Fixes #701

Part of #13224, #15070, #13613

This PR contains the underlying model and change tracking changes needed to support sentinel values. Future PRs will add model building API surface and setting the sentinel automatically based on the database default.

There is a breaking change here: explicitly setting the value of a property with a temporary value no longer automatically makes the value non temporary.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix CSharpRuntimeModelCodeGenerator

…as not been set

Fixes #701

Part of #13224, #15070, #13613

This PR contains the underlying model and change tracking changes needed to support sentinel values. Future PRs will add model building API surface and setting the sentinel automatically based on the database default.

There is a breaking change here: explicitly setting the value of a property with a temporary value no longer automatically makes the value non temporary.
Fixed CSharpRuntimeModelCodeGenerator
@ajcvickers ajcvickers force-pushed the DefaultlyNotFalse0328 branch from 783ed04 to 9c98d59 Compare April 28, 2023 12:26
@ajcvickers
Copy link
Contributor Author

@AndriySvyryd Updated to revert the breaking change and fix CSharpRuntimeModelCodeGenerator

@ajcvickers ajcvickers requested a review from AndriySvyryd April 28, 2023 12:26
@ajcvickers ajcvickers merged commit 3b1ffd9 into main Apr 29, 2023
@ajcvickers ajcvickers deleted the DefaultlyNotFalse0328 branch April 29, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow default value check in value generation to be customized
2 participants