Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse simple default constraint literals when scaffolding #30927

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ajcvickers
Copy link
Contributor

Part of #13613

This is a step closer to being able to scaffold bool columns with default values without using a nullable property or backing field.

@ajcvickers ajcvickers requested a review from a team May 18, 2023 20:20
Part of #13613

This is a step closer to being able to scaffold bool columns with default values without using a nullable property or backing field.

Updated to:
- Move parsing to time database model is created
- Integrate with parsing for CLR defaults
- Updated code generation so that it is only used by scaffolding, not migrations
@ajcvickers ajcvickers force-pushed the TrueByAnyOtherMeasure0509 branch from b6b1ba7 to cdfd214 Compare June 12, 2023 11:08
@ajcvickers
Copy link
Contributor Author

Updated to:

  • Move parsing to time database model is created
  • Integrate with parsing for CLR defaults
  • Updated code generation so that it is only used by scaffolding, not migrations

@ajcvickers ajcvickers requested review from a team and AndriySvyryd June 12, 2023 11:09
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this implementation feels much better to me

@ajcvickers ajcvickers merged commit 101e88e into main Jun 12, 2023
@ajcvickers ajcvickers deleted the TrueByAnyOtherMeasure0509 branch June 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants