Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment test output helpers everywhere #31017

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

roji
Copy link
Member

@roji roji commented Jun 1, 2023

As discussed offline, @maumar.

BTW SetTestOutputHelper doesn't work with non-shared tests - at some point we can take a look at enabling that too.

@roji
Copy link
Member Author

roji commented Jun 1, 2023

So we need to see what to do with the NonShared tests - when SetTestOutputHelper is uncommented on these everything fails with "You must call await InitializeAsync("DatabaseName"); at the beginning of the test."...

@roji
Copy link
Member Author

roji commented Jun 2, 2023

@maumar I reverted the uncommenting for non-shared tests for now - we can merge this for the regular tests and then look at making SetTestOutputHelper work for non-shared ones later.

@maumar
Copy link
Contributor

maumar commented Jun 15, 2023

:shipit:

@roji roji merged commit ef30eb2 into dotnet:main Jun 15, 2023
@roji roji deleted the TestOutputHelper branch June 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants