Partial fix to type mapping inference for primitive collections #31110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
PrimitiveCollectionInference
branch
from
6dbbcc9 to
be7d331
Compare
ajcvickers
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a targeted fix to #31030, but larger type mapping inference problems still remain in the context of primitive collections (see #31109). The issue is that we were checking reference identity between type mappings to detect conflicting/incompatible inferred mappings, but that's two strict, as there could exist two type mapping instances which are equal. Switching to comparing the store type instead.
@ajcvickers should we consider implementing Equals on type mappings, so the we can also make sure that e.g. value converters don't differ?
Closes #31030