Fix NativeAOT warnings in EFCore.Abstractions #31321
Conversation
Use a variable for the TFM to make future upgrades easier. Part of #29761
| [UnconditionalSuppressMessage( | ||
| "ReflectionAnalysis", | ||
| "IL2046", | ||
| Justification = | ||
| "This method is an override, and the base method isn't annotated with RequiresUnreferencedCode. " | ||
| + "The entire type is marked with RequiresUnreferencedCode.")] | ||
| [SuppressMessage("AOT", "IL3051:'RequiresDynamicCodeAttribute' annotations must match across all interface implementations or overrides.", | ||
| Justification = "This method is an override, and the base method isn't annotated with RequiresDynamicCode. " | ||
| + "The entire type is marked with RequiresDynamicCode.")] |
There was a problem hiding this comment.
Should probably open an issue in the linker repo that a type-level [RequiresDynamicCode] should silence all the warnings inside...
There was a problem hiding this comment.
Also add the same for [RequiresUnreferencedCode]
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
Use a variable for the TFM to make future upgrades easier.
Part of #29761