[release/6.0] Cosmos: Persist non-shadow int keys on owned entity types#31936
Merged
ajcvickers merged 1 commit intorelease/6.0from Oct 4, 2023
Merged
[release/6.0] Cosmos: Persist non-shadow int keys on owned entity types#31936ajcvickers merged 1 commit intorelease/6.0from
ajcvickers merged 1 commit intorelease/6.0from
Conversation
Member
|
@AndriySvyryd can you get a code review on this? |
ajcvickers
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #31933
Fixes #31664
Description
When an owned entity type contains and int property that is configured as the key EF assumes that it is a client-generated ordinal that shouldn't be persisted.
Customer impact
For models with matching shape the key property values are replaced with ordinals, causing data loss.
How found
Customer reported on 6.0
Regression
No.
Testing
Added tests.
Risk
Low. Quirked.