[release/8.0] Preserve convertsNulls in the compiled model
#31967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #31942 ### Description Updates to the compiled model resulted in losing the `convertsNulls` state of a value converter. ### Customer impact Silent regression from 7 resulting in different data returned. ### How found Customer reported on daily build. ### Regression Yes. ### Testing Added tests. ### Risk Low.
bricelam
approved these changes
Oct 4, 2023
AndriySvyryd
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31942
Description
Updates to the compiled model resulted in losing the
convertsNullsstate of a value converter.Customer impact
Silent regression from 7 resulting in different data returned.
How found
Customer reported on daily build.
Regression
Yes.
Testing
Added tests.
Risk
Low.