Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Unwrap closures when translating expression trees for compiled model. #31981

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[release/8.0] Unwrap closures when translating expression trees for compiled model. #31981

merged 1 commit into from
Oct 6, 2023

Conversation

AndriySvyryd
Copy link
Member

Fixes #31859

Description

When translating expressions trees for value converters we didn't handle closures correctly.

Customer impact

For models with matching shape the compiled model generation fails.

How found

Discovered during testing on 8.0

Regression

No.

Testing

Added tests.

Risk

Low.

@AndriySvyryd AndriySvyryd requested a review from a team October 5, 2023 23:38
@AndriySvyryd AndriySvyryd force-pushed the Issue31859 branch 3 times, most recently from 77a8e8f to efb1445 Compare October 6, 2023 01:25
roji
roji approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that CSharpRuntimeModelCodeGeneratorTest.cs seems to have had a line ending change in this commit (CRLF -> LF?), making it show up as the whole file being replaced. Just making sure you're aware and this is intentional.

src/EFCore.Design/Query/Internal/LinqToCSharpSyntaxTranslator.cs Outdated Show resolved Hide resolved
@AndriySvyryd
Copy link
Member Author

Note that CSharpRuntimeModelCodeGeneratorTest.cs seems to have had a line ending change in this commit (CRLF -> LF?), making it show up as the whole file being replaced.

No, the file contained some NULL characters and that confuses the tools. That's why these are now escaped.

@AndriySvyryd AndriySvyryd merged commit 4b7812b into release/8.0 Oct 6, 2023
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue31859 branch October 6, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmoseley danmoseley danmoseley left review comments

@roji roji roji approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support value converters with captured state in the compiled model
3 participants
@AndriySvyryd @roji @danmoseley