Shut up and put your RelatedEnd in my Sidecar... #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… navigation to FK fixup) This is very early support for fixup of FKs following navigation property change. Only fixup of dependent to principal reference navigations is supported for now--no collection fixup or inverse property fixup. Specific changes: - Refactor Sidecar to allow it to be used with IPropertyBase and hence navigations as well as normal properties - Similar updates to StateEntry to allow navigation property values to be obtained in the same way as normal property values - Update FK snapshot to also snapshot navigations--will rename in a different checkin - Simple detection of reference changes using the snaphot or notifications triggering a call on the listener that then does simple fixup
| } | ||
| else | ||
| { | ||
| var navigation = propertyBase as INavigation; |
There was a problem hiding this comment.
Can propertyBase be anything other than INavigation on this path? If not a cast may be preferable instead of "as".
There was a problem hiding this comment.
Given that IPropertyBase is a public interface the actual type could be something that is not INavigation. That being said in normal usage it currently will always be an INavigation here. But the idea here is to do something specific to navigations if the property is a navigation, as opposed to do one thing or the other depending on the type, so all in all I feel that the as is more appropriate here.
|
|
|
Merged. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shut up and put your RelatedEnd in my Sidecar... (Initial support for navigation to FK fixup)
This is very early support for fixup of FKs following navigation property change. Only fixup of dependent to principal reference navigations is supported for now--no collection fixup or inverse property fixup. Specific changes: