[release/8.0] Fix to #29156 - TemporalAll for temporal owned entities mapped to parent table. #32031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent table. Similar to JSON entities, owned entities that are mapped to the same table as their owner should be treated as scalars for the purpose of temporal query validation - they are always in sync with the parent entity, so all operations should be allowed for them, not only AsOf. Fixes #29156
| => entityType.IsOwned() | ||
| && entityType.FindOwnership()!.PrincipalEntityType.GetTableMappings().FirstOrDefault()?.Table is ITable ownerTable | ||
| && entityType.GetTableMappings().FirstOrDefault()?.Table is ITable entityTable | ||
| && ownerTable == entityTable; |
There was a problem hiding this comment.
Why are you only checking table mappings, wouldn't the same apply for entity types only mapped to views?
There was a problem hiding this comment.
we don't support "temporal views" (I don't think it's even a thing) - ViewBuilder doesn't have API to set it to temporal.
AndriySvyryd
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to JSON entities, owned entities that are mapped to the same table as their owner should be treated as scalars for the purpose of temporal query validation - they are always in sync with the parent entity, so all operations should be allowed for them, not only AsOf.
Fixes #29156
Risk
Low - this is very similar to the JSON scenario fixed approved for 8.0 recently (see #32006) - we relax the validation we had when encountering navigations with temporal operations. We normally only allow AsOf, otherwise the results are not very useful/coherent, but in case of owned entities mapped to the same table, they are always in sync with parent, so all operations are fine.