Change IStateManager.StartTrackingFromQuery to use ISnapshot instead of ValueBuffer #32099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue31117
branch
3 times, most recently
from
05ee52e to
56df35f
Compare
AndriySvyryd
force-pushed
the
Issue31117
branch
from
56df35f to
3419fbc
Compare
ajcvickers
reviewed
Oct 24, 2023
| @@ -19,73 +19,70 @@ public class CurrentValueComparerFactory | |||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | |||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | |||
| /// </summary> | |||
| public virtual IComparer<IUpdateEntry> Create(IPropertyBase propertyBase) | |||
There was a problem hiding this comment.
Here and other places, why was this previously IPropertyBase?
There was a problem hiding this comment.
Probably a leftover of a design where I was comparing complex properties recursively instead of flattening them.
ajcvickers
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31117