Take into account Contains item visitation in SqlNullabilityProcessor #32214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Nov 2, 2023
| SELECT [p].[Id], [p].[Bool], [p].[Bools], [p].[DateTime], [p].[DateTimes], [p].[Enum], [p].[Enums], [p].[Int], [p].[Ints], [p].[NullableInt], [p].[NullableInts], [p].[NullableString], [p].[NullableStrings], [p].[String], [p].[Strings] | ||
| FROM [PrimitiveCollectionsEntity] AS [p] | ||
| WHERE CASE | ||
| WHEN [p].[Int] IN (1, 2, 3) THEN N'one' |
There was a problem hiding this comment.
We should be getting OPENJSON here; this means that the array parameter is somehow not treated as a primitive query root. Opened #32215 to track.
roji
force-pushed
the
ContainsNullabilityProcessing
branch
from
651b985
to
fee8245
Compare
maumar
approved these changes
Nov 2, 2023
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 9, 2023
…dotnet#32214) Fixes dotnet#32208 (cherry picked from commit 338b76a)
roji
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting non-subquery InExpression in SqlNullabilityProcessor, we were ignoring the results of visiting the item.
Fixes #32208