Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updating complex type properties in ExecuteUpdate #32499

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

roji
Copy link
Member

@roji roji commented Dec 3, 2023

Ths 1st commit in this PR separates out the ExecuteDelete/Update code into separate partial files - no actual change there; so review only the 2nd commit.

This adds support for referencing complex types in ExecuteUpdate's property selector (e.g. context.Customers.ExecuteUpdate(setters => setters.SetProperty(c => c.ShippingAddress, c => c.BillingAddress))). It also does various refactoring/cleanup that simplifies the code, and has a bit of preparation to JSON complex types.

Closes #32058

@roji roji requested a review from a team December 3, 2023 16:37
@roji roji changed the title Execute update complex type Handle updating complex type properties in ExecuteUpdate Dec 3, 2023
@roji roji force-pushed the ExecuteUpdateComplexType branch from 4556993 to 622fe47 Compare December 4, 2023 06:42
@roji roji force-pushed the ExecuteUpdateComplexType branch from 622fe47 to 13bb7d2 Compare December 4, 2023 07:23
@roji
Copy link
Member Author

roji commented Jan 8, 2024

Just a reminder that this is still waiting for a review.

Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't pretend that I have a good understanding here, but from what I can tell, this looks good to me.

@roji roji merged commit 93e0f3a into dotnet:main Jan 11, 2024
7 checks passed
@roji roji deleted the ExecuteUpdateComplexType branch January 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing complex type instances to ExecuteUpdate
2 participants