Stop stripping new lines from migration script literals #32788
Conversation
ajcvickers
force-pushed
the
240111_NotSoClose
branch
from
8b9a152 to
bd74ac4
Compare
| { | ||
| continue; | ||
| } | ||
|
|
||
| var trimmed = line.TrimStart(); | ||
| if (trimmed.StartsWith("GO", StringComparison.OrdinalIgnoreCase) |
There was a problem hiding this comment.
Wouldn't this also happen if a multiline string includes a "GO" line?
There was a problem hiding this comment.
@AndriySvyryd This is true, but I went back to the original regex and it also failed with this case. I'm not sure we can catch this case without really parsing the SQL--we need to know, for sure, are we in a SQL literal or not? I'm thinking we should fix the regression here, and I'll file another issue to discuss if we want to parse this SQL for-real.
Fixes #32730 Will port to 8.0 for patch after merge.
ajcvickers
force-pushed
the
240111_NotSoClose
branch
from
bd74ac4 to
6d1abbf
Compare
* Stop stripping new lines from migration script literals Fixes #32730 Will port to 8.0 for patch after merge. * More tests for cases with GO
|
|
||
| protected override void Up(MigrationBuilder migrationBuilder) | ||
| { | ||
| migrationBuilder.Sql($"INSERT INTO Table1 (Id, Bar, Description) VALUES (-2, ' ', '{TestValue}')"); |
There was a problem hiding this comment.
@ajcvickers this fails on PostgreSQL because of unquoted identifier. Note that GO (below) is in general a SQL Server thing, so maybe move this specific testing to MigrationsInfrastructureSqlServerTest?
Opened #33056.
|
|
||
| protected override void Up(MigrationBuilder migrationBuilder) | ||
| { | ||
| migrationBuilder.Sql($"INSERT INTO Table1 (Id, Bar, Description) VALUES (-2, ' ', '{TestValue}')"); |
There was a problem hiding this comment.
This fails using Pomelo.
Bar (renamed from Foo in 00000000000002_Migration2) is of type int. It is not a string compatible column, but is set to a string with a single whitespace ' ' here in 00000000000005_Migration5.
Leads to the following exception for us:
MySqlConnector.MySqlException (0x80004005): Incorrect integer value: ' ' for column 'Bar' at row 1
at MySqlConnector.Core.ServerSession.ReceiveReplyAsync(IOBehavior ioBehavior, CancellationToken cancellationToken) in D:\Sources\MySqlConnector-8.0\src\MySqlConnector\Core\ServerSession.cs:line 936
at MySqlConnector.Core.ResultSet.ReadResultSetHeaderAsync(IOBehavior ioBehavior) in D:\Sources\MySqlConnector-8.0\src\MySqlConnector\Core\ResultSet.cs:line 37
Opened #33331.
Fixes #32730
Will port to 8.0 for patch after merge.