Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup asserts #32968

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Cleanup asserts #32968

merged 3 commits into from
Feb 3, 2024

Conversation

btecu
Copy link
Contributor

@btecu btecu commented Jan 31, 2024

Use Assert.Null instead of Assert.Equal(null, ...).

  • I've read the guidelines for contributing and seen the walkthrough
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Code follows the same patterns and style as existing code in this repo

@SamMonoRT
Copy link
Member

@btecu
Copy link
Contributor Author

btecu commented Jan 31, 2024

consider updating all instances in the repo https://github.com/search?q=repo%3Adotnet%2Fefcore+%22Assert.Equal%28false%2C%22&type=code

https://github.com/search?q=repo%3Adotnet%2Fefcore+%22Assert.Equal%28true%2C%22&type=code

cc @maumar

It cannot be replaced in many cases, when the type is not boolean but instead is an object.

@maumar maumar merged commit 5e9e4eb into dotnet:main Feb 3, 2024
7 checks passed
@maumar
Copy link
Contributor

maumar commented Feb 3, 2024

@btecu Thank you for the contribution!

roji pushed a commit to roji/efcore that referenced this pull request Feb 9, 2024
* Cleanup asserts

* Assert.True

* fixing compilation error

---------

Co-authored-by: maumar <maumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants