Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33196 command timeout allow zero #33198

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

SteSinger
Copy link
Contributor

@SteSinger SteSinger commented Feb 29, 2024

Allow zero for WithCommandTimeout.
Tests to check that WithCommandTimeout allows zero and rejects negative values

Fixes #33196

Stephan Singer added 3 commits February 29, 2024 11:50
Tests to check that WithCommandTimeout allows zero and rejects negative values
Tests to check that WithCommandTimeout allows zero and rejects negative values

Fixes dotnet#33196
@SteSinger
Copy link
Contributor Author

@dotnet-policy-service agree

@ajcvickers ajcvickers removed the blocked label Mar 1, 2024
@ajcvickers ajcvickers merged commit cf8c023 into dotnet:main Mar 1, 2024
7 checks passed
@ajcvickers
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelationalDbContextOptionsBuilder.CommandTimeout should accept zero as a valid value
2 participants