Change Where_math(f)_log_new_base queries, so they fail if LOG() parameters are swapped
#33342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pomelo user just made us aware in PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1890 that our
Math.Log(double a, double newBase)translation had the parameters swapped (.NET and MySQL use a different parameter order).Looks like the
Where_math_log_new_baseandWhere_mathf_log_new_basetests coincidentally succeed anyway with swapped arguments.This PR ensures that those tests fail with swapped arguments.