Consolidate primitive collections across relational and Cosmos #33456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Apr 2, 2024
| /// <typeparam name="TElement">The element type.</typeparam> | ||
| public sealed class ListComparer<TElement> : ValueComparer<IEnumerable<TElement>> | ||
| public sealed class ListComparer<TConcreteCollection, TElement> : ValueComparer<IEnumerable<TElement>> | ||
| where TElement : struct |
There was a problem hiding this comment.
Consider renaming this to ValueTypeListComparer
AndriySvyryd
reviewed
Apr 2, 2024
AndriySvyryd
reviewed
Apr 2, 2024
src/EFCore/Storage/Json/JsonCollectionOfReferencesReaderWriter.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Apr 2, 2024
src/EFCore/Storage/Json/JsonCollectionOfReferencesReaderWriter.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Apr 3, 2024
AndriySvyryd
approved these changes
Apr 3, 2024
|
Add a nested primitive collection to |
This change starts using the EF8 primitive collection infrastructure for primitive collections in Cosmos. This involves adding support for nested collections and read-only collections. The main challenge here is supporting all the different collection types when, for example, `List<List<string>>` cannot be cast to `IEnumerable<IEnumerable<string>>`. To support this, we use exact collection types in snapshots, and we use non-generic methods in the nested comparers and serializers. General dictionary mapping still not supported. No extensive query testing done yet. Model building and change tracking for #30713 Fixes #25364 Fixes #25343 Part of #4179 Fixes #31722
ajcvickers
force-pushed
the
240327_Primates
branch
from
7dac2f0 to
8942753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change starts using the EF8 primitive collection infrastructure for primitive collections in Cosmos. This involves adding support for nested collections and read-only collections.
The main challenge here is supporting all the different collection types when, for example,
List<List<string>>cannot be cast toIEnumerable<IEnumerable<string>>. To support this, we use exact collection types in snapshots, and we use non-generic methods in the nested comparers and serializers.General dictionary mapping still not supported.
No extensive query testing done yet.
Model building and change tracking for #30713
Fixes #25364
Fixes #25343
Part of #4179
Fixes #31722