[release/6.0] Update dependencies #34821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
reviewed
Oct 3, 2024
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.29.0" /> | |||
| <PackageReference Include="System.Net.Http" Version="4.3.4" /> | |||
| <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" /> | |||
There was a problem hiding this comment.
These two indeed are dropped by conflict resolution, so it's annoying we need to specify them. The end up being brought in by Newtonsoft.Json which Cosmos doesn't want to update. Azure/azure-cosmos-dotnet-v3#4674
ericstj
reviewed
Oct 3, 2024
| @@ -21,6 +21,9 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Data.SqlClient" Version="2.1.7" /> | |||
| <PackageReference Include="System.Drawing.Common" Version="4.7.3" /> | |||
There was a problem hiding this comment.
These ones are real transitive vulnerabilities. Nothing else is going to drop these or update them. Unfortunately SqlClient hasn't shipped an update to address them. Maybe they would consider it? I see version 2.1.7 was shipped less than a year ago.
There was a problem hiding this comment.
They've been informed of this offline, but they don't plan to ship an update as this vulnerability does not affect SqlClient
cincuranet
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a recent change NuGet restore now shows CVE warnings for transitive packages even if the actual version that will be used will be the current one provided by SDK. This PR updates transitive dependencies to minimize the number of warnings
Customer impact
Warnings on restore when EF packages are referenced.
How found
Partner ask (templates)
Regression
No
Testing
Tested manually.
Risk
Low.