Lift try..catch out of an expression and replace with a temporary variable #34912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
EnableDetailedErrors
is turned on it wraps the expression to read the field value in a try...catch statementIn certain situations this is not valid C#
NewExpression
Also fixed some of the catch handling
ThrowExtractJsonPropertyException
needs to be public for it to be called (likeThrowReadValueException
already is)property.Name
rather than justproperty
property
is null so handle that for the call toThrowReadValueException
as wellFixes #34393