Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BinSkim and prefast #35272

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Update BinSkim and prefast #35272

merged 1 commit into from
Dec 7, 2024

Conversation

AndriySvyryd
Copy link
Member

Explicitly disable BinSkim on Linux as it does not run successfully
Update SDL baseline
Make the build deterministic

@AndriySvyryd
Update binskim and prefast
6ea4bbd 
Make the build deterministic
Disable BinSkim on non-Windows legs
@AndriySvyryd AndriySvyryd requested a review from maumar as a code owner December 4, 2024 19:59
@AndriySvyryd AndriySvyryd requested a review from Copilot December 4, 2024 21:08
Copilot
Copilot AI reviewed Dec 4, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • Directory.Build.props: Language not supported

azure-pipelines.yml Show resolved Hide resolved
@SamMonoRT
Copy link
Member

LGTM - ready to merge

@AndriySvyryd AndriySvyryd merged commit f981c8f into main Dec 7, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the BinSkim branch December 7, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@SamMonoRT SamMonoRT SamMonoRT approved these changes

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @SamMonoRT @maumar