API review modifications to ParametersCacheDecorator #36549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Entity Framework Core parameter handling API by renaming CacheSafeParameterFacade to ParametersCacheDecorator and updating related method names to improve clarity and consistency.
- Renames the core parameter handling class from
CacheSafeParameterFacadetoParametersCacheDecorator - Updates method names to be more descriptive (
IsParameterNull→IsNull,GetParametersAndDisableSqlCaching→GetAndDisableCaching) - Modernizes constructor syntax in SQL processor classes using primary constructors
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ParametersCacheDecorator.cs | Renames class and methods, updates documentation to reflect "decorator" pattern terminology |
| SqlNullabilityProcessor.cs | Updates all references to use new class and method names |
| RelationalParameterBasedSqlProcessor.cs | Updates method signatures and calls to use new parameter type and names |
| RelationalParameterProcessor.cs | Updates field names and method calls to use new decorator class |
| SqliteParameterBasedSqlProcessor.cs | Modernizes constructor and updates method parameter types |
| SqlServerParameterBasedSqlProcessor.cs | Modernizes constructor and updates method signatures |
| SqlServerSqlNullabilityProcessor.cs | Updates method signatures and calls to use new decorator |
| SqlServerZeroLimitConverter.cs | Updates field names and method calls to use new decorator |
cincuranet
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35722