[RC2, TESTS] Complex type test fixes#36595
Merged
roji merged 1 commit intodotnet:release/10.0from Aug 19, 2025
Merged
Conversation
roji
changed the title
| OFFSET 0 ROWS FETCH NEXT 1 ROWS ONLY) = 8 | ||
| ORDER BY [r].[Id], [o].[RootEntityId], [o0].[RelatedTypeRootEntityId], [o1].[RelatedTypeRootEntityId], [r1].[RootEntityId], [r2].[RelatedTypeRootEntityId], [r3].[RelatedTypeRootEntityId], [o2].[RelatedTypeRootEntityId], [o2].[Id], [s].[RootEntityId], [s].[Id], [s].[RelatedTypeRootEntityId], [s].[RelatedTypeId], [s].[RelatedTypeRootEntityId0], [s].[RelatedTypeId0], [s].[RelatedTypeRootEntityId1], [s].[RelatedTypeId1], [s].[Id0], [r8].[RelatedTypeRootEntityId] | ||
| """); | ||
| AssertSql(); |
Member
Author
There was a problem hiding this comment.
In the context of this suite (non-JSON owned navigations), the test uses non-deterministic ordering (indexing without previous OrderBy). Now, there was a bug (which this PR fixes) which caused the "non-deterministic query" error to not be thrown, and the test happened to pass on SQL Server, but it failed on PostgreSQL because the ordering was different. After this PR, the base implementation of this test for non-JSON owned navigations ensures that the error is thrown, and so no SQL gets generated.
AndriySvyryd
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fixes that came out of synchronizing the PostgreSQL providers (plus a couple of cosmetic-only product code changes) - tell mode for rc.2.
/cc @artl93