Skip to content

Conversation

@AndriySvyryd
Copy link
Member

Fixes #7201

@AndriySvyryd AndriySvyryd requested a review from Copilot August 18, 2025 18:26
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner August 18, 2025 18:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR systematically improves the grammar, style, and punctuation of exception messages across the Entity Framework Core codebase to enhance clarity and consistency. The changes follow established conventions for error message formatting while maintaining technical accuracy.

Key changes include:

  • Standardizing error message structure and punctuation
  • Replacing hardcoded exception messages with localized string resources
  • Ensuring consistent formatting of code elements and values

Reviewed Changes

Copilot reviewed 13 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/EFCore/Query/ParameterQueryRootExpression.cs Replaces hardcoded exception messages with localized string resource
src/EFCore/Properties/CoreStrings.resx Updates numerous error messages for improved grammar, style, and consistency
src/EFCore.Sqlite.NTS/Properties/SqliteNTSStrings.resx Improves error message formatting and clarity
src/EFCore.Sqlite.Core/Properties/SqliteStrings.resx Enhances error message grammar and consistency
src/EFCore.SqlServer/Properties/SqlServerStrings.resx Fixes grammar and style issues in error messages
src/EFCore.SqlServer.NTS/Properties/SqlServerNTSStrings.resx Improves method name formatting consistency
src/EFCore.SqlServer.HierarchyId/Properties/SqlServerHierarchyIdStrings.resx Updates method name formatting for consistency
src/EFCore.Relational/Properties/RelationalStrings.resx Extensive grammar and style improvements across many error messages
src/EFCore.Proxies/Properties/ProxiesStrings.resx Improves method name formatting consistency
src/EFCore.InMemory/Properties/InMemoryStrings.resx Fixes grammar in error messages
src/EFCore.Design/Properties/DesignStrings.resx Improves error message clarity and formatting
src/EFCore.Cosmos/Properties/CosmosStrings.resx Enhances error message grammar and consistency
src/EFCore.Abstractions/Properties/AbstractionsStrings.resx Fixes grammatical error in argument validation message
Files not reviewed (12)
  • src/EFCore.Abstractions/Properties/AbstractionsStrings.Designer.cs: Language not supported
  • src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Language not supported
  • src/EFCore.Design/Properties/DesignStrings.Designer.cs: Language not supported
  • src/EFCore.InMemory/Properties/InMemoryStrings.Designer.cs: Language not supported
  • src/EFCore.Proxies/Properties/ProxiesStrings.Designer.cs: Language not supported
  • src/EFCore.Relational/Properties/RelationalStrings.Designer.cs: Language not supported
  • src/EFCore.SqlServer.HierarchyId/Properties/SqlServerHierarchyIdStrings.Designer.cs: Language not supported
  • src/EFCore.SqlServer.NTS/Properties/SqlServerNTSStrings.Designer.cs: Language not supported
  • src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs: Language not supported
  • src/EFCore.Sqlite.Core/Properties/SqliteStrings.Designer.cs: Language not supported
  • src/EFCore.Sqlite.NTS/Properties/SqliteNTSStrings.Designer.cs: Language not supported
  • src/EFCore/Properties/CoreStrings.Designer.cs: Language not supported

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@AndriySvyryd AndriySvyryd requested a review from artl93 August 18, 2025 18:28
@AndriySvyryd AndriySvyryd changed the title Fix grammar, style and punctuation issues in exception messages [rc2] Fix grammar, style and punctuation issues in exception messages Aug 18, 2025
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@AndriySvyryd AndriySvyryd enabled auto-merge (squash) August 18, 2025 18:53
@AndriySvyryd AndriySvyryd merged commit b86bdbb into release/10.0 Aug 18, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue7201 branch August 18, 2025 19:34
@SamMonoRT
Copy link
Member

@AndriySvyryd @roji - do we need to flag anything special to allow for localization updates anywhere?

@roji
Copy link
Member

roji commented Aug 19, 2025

@SamMonoRT not as far as I know - this is something that's automatically taken care of without anything needed from us.

@AndriySvyryd
Copy link
Member Author

There's no localization

@roji
Copy link
Member

roji commented Aug 19, 2025

(oops, thought this was about conceptual docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception message review

5 participants