-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[rc2] Fix grammar, style and punctuation issues in exception messages #36597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR systematically improves the grammar, style, and punctuation of exception messages across the Entity Framework Core codebase to enhance clarity and consistency. The changes follow established conventions for error message formatting while maintaining technical accuracy.
Key changes include:
- Standardizing error message structure and punctuation
- Replacing hardcoded exception messages with localized string resources
- Ensuring consistent formatting of code elements and values
Reviewed Changes
Copilot reviewed 13 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/EFCore/Query/ParameterQueryRootExpression.cs | Replaces hardcoded exception messages with localized string resource |
| src/EFCore/Properties/CoreStrings.resx | Updates numerous error messages for improved grammar, style, and consistency |
| src/EFCore.Sqlite.NTS/Properties/SqliteNTSStrings.resx | Improves error message formatting and clarity |
| src/EFCore.Sqlite.Core/Properties/SqliteStrings.resx | Enhances error message grammar and consistency |
| src/EFCore.SqlServer/Properties/SqlServerStrings.resx | Fixes grammar and style issues in error messages |
| src/EFCore.SqlServer.NTS/Properties/SqlServerNTSStrings.resx | Improves method name formatting consistency |
| src/EFCore.SqlServer.HierarchyId/Properties/SqlServerHierarchyIdStrings.resx | Updates method name formatting for consistency |
| src/EFCore.Relational/Properties/RelationalStrings.resx | Extensive grammar and style improvements across many error messages |
| src/EFCore.Proxies/Properties/ProxiesStrings.resx | Improves method name formatting consistency |
| src/EFCore.InMemory/Properties/InMemoryStrings.resx | Fixes grammar in error messages |
| src/EFCore.Design/Properties/DesignStrings.resx | Improves error message clarity and formatting |
| src/EFCore.Cosmos/Properties/CosmosStrings.resx | Enhances error message grammar and consistency |
| src/EFCore.Abstractions/Properties/AbstractionsStrings.resx | Fixes grammatical error in argument validation message |
Files not reviewed (12)
- src/EFCore.Abstractions/Properties/AbstractionsStrings.Designer.cs: Language not supported
- src/EFCore.Cosmos/Properties/CosmosStrings.Designer.cs: Language not supported
- src/EFCore.Design/Properties/DesignStrings.Designer.cs: Language not supported
- src/EFCore.InMemory/Properties/InMemoryStrings.Designer.cs: Language not supported
- src/EFCore.Proxies/Properties/ProxiesStrings.Designer.cs: Language not supported
- src/EFCore.Relational/Properties/RelationalStrings.Designer.cs: Language not supported
- src/EFCore.SqlServer.HierarchyId/Properties/SqlServerHierarchyIdStrings.Designer.cs: Language not supported
- src/EFCore.SqlServer.NTS/Properties/SqlServerNTSStrings.Designer.cs: Language not supported
- src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs: Language not supported
- src/EFCore.Sqlite.Core/Properties/SqliteStrings.Designer.cs: Language not supported
- src/EFCore.Sqlite.NTS/Properties/SqliteNTSStrings.Designer.cs: Language not supported
- src/EFCore/Properties/CoreStrings.Designer.cs: Language not supported
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
040b473 to
1f8874a
Compare
artl93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
|
@AndriySvyryd @roji - do we need to flag anything special to allow for localization updates anywhere? |
|
@SamMonoRT not as far as I know - this is something that's automatically taken care of without anything needed from us. |
|
There's no localization |
|
(oops, thought this was about conceptual docs) |
Fixes #7201